diff options
| author | Aruna Balakrishnaiah <aruna@linux.vnet.ibm.com> | 2013-06-25 14:33:56 +0530 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2015-02-05 22:35:39 -0800 |
| commit | 841eb01f53cdb78d840dc4000f103fa7dd4228d2 (patch) | |
| tree | 27a0d08baa988077b04f13c4b8a66be81ebe9296 /fs | |
| parent | b12835bdb935057b69b0b9059226f554a926415e (diff) | |
| download | lwn-841eb01f53cdb78d840dc4000f103fa7dd4228d2.tar.gz lwn-841eb01f53cdb78d840dc4000f103fa7dd4228d2.zip | |
pstore: Fail to unlink if a driver has not defined pstore_erase
commit bf2883339a33b7544b92ea465b90c3de55082032 upstream.
pstore_erase is used to erase the record from the persistent store.
So if a driver has not defined pstore_erase callback return
-EPERM instead of unlinking a file as deleting the file without
erasing its record in persistent store will give a wrong impression
to customers.
Signed-off-by: Aruna Balakrishnaiah <aruna@linux.vnet.ibm.com>
Acked-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Tony Luck <tony.luck@intel.com>
Cc: HuKeping <hukeping@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/pstore/inode.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/pstore/inode.c b/fs/pstore/inode.c index 3ba30825f387..eaba02d951d3 100644 --- a/fs/pstore/inode.c +++ b/fs/pstore/inode.c @@ -178,6 +178,8 @@ static int pstore_unlink(struct inode *dir, struct dentry *dentry) if (p->psi->erase) p->psi->erase(p->type, p->id, p->count, dentry->d_inode->i_ctime, p->psi); + else + return -EPERM; return simple_unlink(dir, dentry); } |