diff options
| author | Jan Kara <jack@suse.cz> | 2011-04-27 18:20:44 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2011-06-03 10:33:52 +0900 |
| commit | d5994d14b3697d22117b2e3c91317c4bff87803a (patch) | |
| tree | 1baf739c646158202510e9390151237840696ed6 /fs | |
| parent | 811dfd3f3d8304443b9dc5a74a953f1b907e6129 (diff) | |
| download | lwn-d5994d14b3697d22117b2e3c91317c4bff87803a.tar.gz lwn-d5994d14b3697d22117b2e3c91317c4bff87803a.zip | |
ext3: Fix fs corruption when make_indexed_dir() fails
commit 86c4f6d85595cd7da635dc6985d27bfa43b1ae10 upstream.
When make_indexed_dir() fails (e.g. because of ENOSPC) after it has allocated
block for index tree root, we did not properly mark all changed buffers dirty.
This lead to only some of these buffers being written out and thus effectively
corrupting the directory.
Fix the issue by marking all changed data dirty even in the error failure case.
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/ext3/namei.c | 13 |
1 files changed, 11 insertions, 2 deletions
diff --git a/fs/ext3/namei.c b/fs/ext3/namei.c index 75c968eaf90d..d5d35d7d2bd0 100644 --- a/fs/ext3/namei.c +++ b/fs/ext3/namei.c @@ -1416,10 +1416,19 @@ static int make_indexed_dir(handle_t *handle, struct dentry *dentry, frame->at = entries; frame->bh = bh; bh = bh2; + /* + * Mark buffers dirty here so that if do_split() fails we write a + * consistent set of buffers to disk. + */ + ext3_journal_dirty_metadata(handle, frame->bh); + ext3_journal_dirty_metadata(handle, bh); de = do_split(handle,dir, &bh, frame, &hinfo, &retval); - dx_release (frames); - if (!(de)) + if (!de) { + ext3_mark_inode_dirty(handle, dir); + dx_release(frames); return retval; + } + dx_release(frames); return add_dirent_to_buf(handle, dentry, inode, de, bh); } |