diff options
| author | Sunil Mushran <sunil.mushran@oracle.com> | 2010-08-12 16:24:26 -0700 |
|---|---|---|
| committer | Paul Gortmaker <paul.gortmaker@windriver.com> | 2011-01-06 18:07:41 -0500 |
| commit | 654a3ffcdf03dc238a23f4572544392516d6daa1 (patch) | |
| tree | dd749739d3a2af2771b69c11735a5cebf8f2a443 /fs | |
| parent | 5ba16d7c0e8cc1e32b00c05d08725252f33a1415 (diff) | |
| download | lwn-654a3ffcdf03dc238a23f4572544392516d6daa1.tar.gz lwn-654a3ffcdf03dc238a23f4572544392516d6daa1.zip | |
ocfs2: Fix incorrect checksum validation error
commit f5ce5a08a40f2086435858ddc80cb40394b082eb upstream.
For local mounts, ocfs2_read_locked_inode() calls ocfs2_read_blocks_sync() to
read the inode off the disk. The latter first checks to see if that block is
cached in the journal, and, if so, returns that block. That is ok.
But ocfs2_read_locked_inode() goes wrong when it tries to validate the checksum
of such blocks. Blocks that are cached in the journal may not have had their
checksum computed as yet. We should not validate the checksums of such blocks.
Fixes ossbz#1282
http://oss.oracle.com/bugzilla/show_bug.cgi?id=1282
Signed-off-by: Sunil Mushran <sunil.mushran@oracle.com>
Singed-off-by: Tao Ma <tao.ma@oracle.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/ocfs2/inode.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/fs/ocfs2/inode.c b/fs/ocfs2/inode.c index af189887201c..bbecb190ce14 100644 --- a/fs/ocfs2/inode.c +++ b/fs/ocfs2/inode.c @@ -484,7 +484,11 @@ static int ocfs2_read_locked_inode(struct inode *inode, OCFS2_BH_IGNORE_CACHE); } else { status = ocfs2_read_blocks_sync(osb, args->fi_blkno, 1, &bh); - if (!status) + /* + * If buffer is in jbd, then its checksum may not have been + * computed as yet. + */ + if (!status && !buffer_jbd(bh)) status = ocfs2_validate_inode_block(osb->sb, bh); } if (status < 0) { |