diff options
| author | Dan Carpenter <error27@gmail.com> | 2010-04-22 11:39:29 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2010-05-12 14:57:03 -0700 |
| commit | 8cab1cb1cddb0731a0597575389230389ddea882 (patch) | |
| tree | df2319d831d17d48b47d0947e774b0f0b4684995 /fs | |
| parent | beeaab03ee04e5dd5e0ce48732a0d8e59554ef54 (diff) | |
| download | lwn-8cab1cb1cddb0731a0597575389230389ddea882.tar.gz lwn-8cab1cb1cddb0731a0597575389230389ddea882.zip | |
ocfs2: potential ERR_PTR dereference on error paths
commit 0350cb078f5035716ebdad4ad4709d02fe466a8a upstream.
If "handle" is non null at the end of the function then we assume it's a
valid pointer and pass it to ocfs2_commit_trans();
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Joel Becker <joel.becker@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/ocfs2/inode.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/ocfs2/inode.c b/fs/ocfs2/inode.c index 0297fb8982b8..4c827d865474 100644 --- a/fs/ocfs2/inode.c +++ b/fs/ocfs2/inode.c @@ -559,6 +559,7 @@ static int ocfs2_truncate_for_delete(struct ocfs2_super *osb, handle = ocfs2_start_trans(osb, OCFS2_INODE_UPDATE_CREDITS); if (IS_ERR(handle)) { status = PTR_ERR(handle); + handle = NULL; mlog_errno(status); goto out; } |