diff options
author | Eric Sandeen <sandeen@sandeen.net> | 2018-06-08 09:53:49 -0700 |
---|---|---|
committer | Darrick J. Wong <darrick.wong@oracle.com> | 2018-06-08 10:07:52 -0700 |
commit | bb3d48dcf86a97dc25fe9fc2c11938e19cb4399a (patch) | |
tree | f90fb947d2782328cc8ce412441b3fffa5b30d41 /fs/xfs/xfs_log_recover.c | |
parent | 9bb54cb56ae8498d35392745f8f050112cec5dcb (diff) | |
download | lwn-bb3d48dcf86a97dc25fe9fc2c11938e19cb4399a.tar.gz lwn-bb3d48dcf86a97dc25fe9fc2c11938e19cb4399a.zip |
xfs: don't call xfs_da_shrink_inode with NULL bp
xfs_attr3_leaf_create may have errored out before instantiating a buffer,
for example if the blkno is out of range. In that case there is no work
to do to remove it, and in fact xfs_da_shrink_inode will lead to an oops
if we try.
This also seems to fix a flaw where the original error from
xfs_attr3_leaf_create gets overwritten in the cleanup case, and it
removes a pointless assignment to bp which isn't used after this.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=199969
Reported-by: Xu, Wen <wen.xu@gatech.edu>
Tested-by: Xu, Wen <wen.xu@gatech.edu>
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Diffstat (limited to 'fs/xfs/xfs_log_recover.c')
0 files changed, 0 insertions, 0 deletions