diff options
author | Darrick J. Wong <djwong@kernel.org> | 2023-09-11 08:39:07 -0700 |
---|---|---|
committer | Darrick J. Wong <djwong@kernel.org> | 2023-09-12 10:31:07 -0700 |
commit | 83771c50e42b92de6740a63e152c96c052d37736 (patch) | |
tree | a8d16d2d2249f6972872b16611a62fbe30850229 /fs/xfs/xfs_export.c | |
parent | f12b96683d6976a3a07fdf3323277c79dbe8f6ab (diff) | |
download | lwn-83771c50e42b92de6740a63e152c96c052d37736.tar.gz lwn-83771c50e42b92de6740a63e152c96c052d37736.zip |
xfs: reload entire unlinked bucket lists
The previous patch to reload unrecovered unlinked inodes when adding a
newly created inode to the unlinked list is missing a key piece of
functionality. It doesn't handle the case that someone calls xfs_iget
on an inode that is not the last item in the incore list. For example,
if at mount time the ondisk iunlink bucket looks like this:
AGI -> 7 -> 22 -> 3 -> NULL
None of these three inodes are cached in memory. Now let's say that
someone tries to open inode 3 by handle. We need to walk the list to
make sure that inodes 7 and 22 get loaded cold, and that the
i_prev_unlinked of inode 3 gets set to 22.
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Diffstat (limited to 'fs/xfs/xfs_export.c')
-rw-r--r-- | fs/xfs/xfs_export.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/fs/xfs/xfs_export.c b/fs/xfs/xfs_export.c index 1064c2342876..f71ea786a6d2 100644 --- a/fs/xfs/xfs_export.c +++ b/fs/xfs/xfs_export.c @@ -146,6 +146,12 @@ xfs_nfs_get_inode( return ERR_PTR(error); } + error = xfs_inode_reload_unlinked(ip); + if (error) { + xfs_irele(ip); + return ERR_PTR(error); + } + if (VFS_I(ip)->i_generation != generation) { xfs_irele(ip); return ERR_PTR(-ESTALE); |