diff options
| author | Adrian Bunk <bunk@stusta.de> | 2006-08-30 13:41:58 +1000 |
|---|---|---|
| committer | Nathan Scott <nathans@sgi.com> | 2006-08-30 13:41:58 +1000 |
| commit | 7288026b8671061aff7663b1766037b3f2573627 (patch) | |
| tree | 6b1815edfdc11e95eb9669f471a8233a04943d21 /fs/xfs/xfs_bmap.c | |
| parent | 1ad8f401b6e16e3ba8a70dcda466e7a0986f7e5e (diff) | |
| download | lwn-7288026b8671061aff7663b1766037b3f2573627.tar.gz lwn-7288026b8671061aff7663b1766037b3f2573627.zip | |
[XFS] Fix char size overflow in bmap_alloc call for unwritten extent
conversion.
Since bma.conv is a char and XFS_BMAPI_CONVERT is 0x1000, bma.conv was
always assigned zero. Spotted by the GNU C compiler (SVN version).
SGI-PV: 947312
SGI-Modid: xfs-linux-melb:xfs-kern:26887a
Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Nathan Scott <nathans@sgi.com>
Diffstat (limited to 'fs/xfs/xfs_bmap.c')
| -rw-r--r-- | fs/xfs/xfs_bmap.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/xfs/xfs_bmap.c b/fs/xfs/xfs_bmap.c index 3a6137539064..bf46fae303af 100644 --- a/fs/xfs/xfs_bmap.c +++ b/fs/xfs/xfs_bmap.c @@ -4993,7 +4993,7 @@ xfs_bmapi( bma.firstblock = *firstblock; bma.alen = alen; bma.off = aoff; - bma.conv = (flags & XFS_BMAPI_CONVERT); + bma.conv = !!(flags & XFS_BMAPI_CONVERT); bma.wasdel = wasdelay; bma.minlen = minlen; bma.low = flist->xbf_low; |