diff options
| author | Darrick J. Wong <djwong@kernel.org> | 2023-12-15 10:03:37 -0800 |
|---|---|---|
| committer | Darrick J. Wong <djwong@kernel.org> | 2023-12-15 10:03:37 -0800 |
| commit | 6c7289528d3c91855d78c56bb35fa360ed9a40bd (patch) | |
| tree | 93edc842db6462f2a98ec8c0b72d4d55284373ea /fs/xfs/scrub/common.c | |
| parent | e744cef206055954517648070d2b3aaa3d2515ba (diff) | |
| download | lwn-6c7289528d3c91855d78c56bb35fa360ed9a40bd.tar.gz lwn-6c7289528d3c91855d78c56bb35fa360ed9a40bd.zip | |
xfs: abort directory parent scrub scans if we encounter a zapped directory
In a previous patch, we added some code to perform sufficient repairs
to an ondisk inode record such that the inode cache would be willing to
load the inode. If the broken inode was a shortform directory, it will
reset the directory to something plausible, which is to say an empty
subdirectory of the root. The telltale signs that something is
seriously wrong is the broken link count.
Such directories look clean, but they shouldn't participate in a
filesystem scan to find or confirm a directory parent pointer. Create a
predicate that identifies such directories and abort the scrub.
Found by fuzzing xfs/1554 with multithreaded xfs_scrub enabled and
u3.bmx[0].startblock = zeroes.
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'fs/xfs/scrub/common.c')
| -rw-r--r-- | fs/xfs/scrub/common.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/xfs/scrub/common.c b/fs/xfs/scrub/common.c index f0207e71e5dc..81f2b96bb5a7 100644 --- a/fs/xfs/scrub/common.c +++ b/fs/xfs/scrub/common.c @@ -25,6 +25,7 @@ #include "xfs_trans_priv.h" #include "xfs_da_format.h" #include "xfs_da_btree.h" +#include "xfs_dir2_priv.h" #include "xfs_attr.h" #include "xfs_reflink.h" #include "xfs_ag.h" |