summaryrefslogtreecommitdiff
path: root/fs/xfs/libxfs/xfs_dir2_node.c
diff options
context:
space:
mode:
authorEric Sandeen <sandeen@redhat.com>2016-03-15 11:42:47 +1100
committerDave Chinner <david@fromorbit.com>2016-03-15 11:42:47 +1100
commitcc07eed8336d6452214d13e0cba770a0f5296a7f (patch)
treec480a343183a036e4c46b02b8e4714f5aea0d9b5 /fs/xfs/libxfs/xfs_dir2_node.c
parentd34999c97ae87cd56514b8cbc6269651efe274fe (diff)
downloadlwn-cc07eed8336d6452214d13e0cba770a0f5296a7f.tar.gz
lwn-cc07eed8336d6452214d13e0cba770a0f5296a7f.zip
xfs: ensure committed is initialized in xfs_trans_roll
__xfs_trans_roll() can return without setting the *committed argument; this was a problem for xfs_bmap_finish(): int committed;/* xact committed or not */ ... error = __xfs_trans_roll(tp, ip, &committed); if (error) { ... if (committed) { and we tested an uninitialized "committed" variable on the error path. No caller is preserving "committed" state across calls to __xfs_trans_roll(), so just initialize committed inside the function to avoid future errors like this. Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Eric Sandeen <sandeen@redhat.com> Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Dave Chinner <david@fromorbit.com>
Diffstat (limited to 'fs/xfs/libxfs/xfs_dir2_node.c')
0 files changed, 0 insertions, 0 deletions