diff options
| author | Andreas Gruenbacher <agruenba@redhat.com> | 2016-09-29 17:48:40 +0200 |
|---|---|---|
| committer | Al Viro <viro@zeniv.linux.org.uk> | 2016-10-07 20:10:43 -0400 |
| commit | 5f6e59ae8277cef221fdbf9b12f0c4f80db59944 (patch) | |
| tree | be029e6b617f66cb314481283bd5cf6553495e76 /fs/xattr.c | |
| parent | d0a5b995a308347fdb1bb0412df32acd0312523b (diff) | |
| download | lwn-5f6e59ae8277cef221fdbf9b12f0c4f80db59944.tar.gz lwn-5f6e59ae8277cef221fdbf9b12f0c4f80db59944.zip | |
vfs: Use IOP_XATTR flag for bad-inode handling
With this change, all the xattr handler based operations will produce an
-EIO result for bad inodes, and we no longer only depend on inode->i_op
to be set to bad_inode_ops.
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/xattr.c')
| -rw-r--r-- | fs/xattr.c | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/fs/xattr.c b/fs/xattr.c index 38b52a356d1b..1f5d0b48422a 100644 --- a/fs/xattr.c +++ b/fs/xattr.c @@ -58,8 +58,11 @@ xattr_resolve_name(struct inode *inode, const char **name) const struct xattr_handler **handlers = inode->i_sb->s_xattr; const struct xattr_handler *handler; - if (!(inode->i_opflags & IOP_XATTR)) + if (!(inode->i_opflags & IOP_XATTR)) { + if (unlikely(is_bad_inode(inode))) + return ERR_PTR(-EIO); return ERR_PTR(-EOPNOTSUPP); + } for_each_xattr_handler(handlers, handler) { const char *n; @@ -168,6 +171,9 @@ int __vfs_setxattr_noperm(struct dentry *dentry, const char *name, } } else if (issec) { const char *suffix = name + XATTR_SECURITY_PREFIX_LEN; + + if (unlikely(is_bad_inode(inode))) + return -EIO; error = security_inode_setsecurity(inode, suffix, value, size, flags); if (!error) |