diff options
| author | Jan Kara <jack@suse.cz> | 2019-02-19 14:59:43 +0100 |
|---|---|---|
| committer | Jan Kara <jack@suse.cz> | 2019-02-21 19:25:36 +0100 |
| commit | 52b9666efd8b0874d334de718a7d561e7b0eb1cc (patch) | |
| tree | a583ede10c8506825c2a8a6d7bccc1e6d66b441a /fs/udf | |
| parent | 93bc420ed41df63a18ae794101f7cbf45226a6ef (diff) | |
| download | lwn-52b9666efd8b0874d334de718a7d561e7b0eb1cc.tar.gz lwn-52b9666efd8b0874d334de718a7d561e7b0eb1cc.zip | |
udf: Drop pointless check from udf_sync_fs()
The check if (bh) in udf_sync_fs() is pointless as we cannot have
sbi->s_lvid_dirty and !sbi->s_lvid_bh (as already asserted by
udf_updated_lvid()). So just drop the pointless check.
Reviewed-by: Steven J. Magnani <steve@digidescorp.com>
Reported-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Jan Kara <jack@suse.cz>
Diffstat (limited to 'fs/udf')
| -rw-r--r-- | fs/udf/super.c | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/fs/udf/super.c b/fs/udf/super.c index a6940d90bedd..ffd8038ff728 100644 --- a/fs/udf/super.c +++ b/fs/udf/super.c @@ -2330,13 +2330,10 @@ static int udf_sync_fs(struct super_block *sb, int wait) mutex_lock(&sbi->s_alloc_mutex); if (sbi->s_lvid_dirty) { struct buffer_head *bh = sbi->s_lvid_bh; + struct logicalVolIntegrityDesc *lvid; - if (bh) { - struct logicalVolIntegrityDesc *lvid; - - lvid = (struct logicalVolIntegrityDesc *)bh->b_data; - udf_finalize_lvid(lvid); - } + lvid = (struct logicalVolIntegrityDesc *)bh->b_data; + udf_finalize_lvid(lvid); /* * Blockdevice will be synced later so we don't have to submit |