diff options
| author | Markus Elfring <elfring@users.sourceforge.net> | 2014-11-18 17:17:46 +0100 |
|---|---|---|
| committer | Jan Kara <jack@suse.cz> | 2014-11-19 21:55:45 +0100 |
| commit | 0d454e4a443178863f858cdafac870ceb1989407 (patch) | |
| tree | 7dfb38bffe7efbbf049d13eeee861da425e1e221 /fs/udf | |
| parent | 11cc9f56a18d371634d07b1be7e8772f6f7dcec5 (diff) | |
| download | lwn-0d454e4a443178863f858cdafac870ceb1989407.tar.gz lwn-0d454e4a443178863f858cdafac870ceb1989407.zip | |
udf: Deletion of unnecessary checks before the function call "iput"
The iput() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Jan Kara <jack@suse.cz>
Diffstat (limited to 'fs/udf')
| -rw-r--r-- | fs/udf/super.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/fs/udf/super.c b/fs/udf/super.c index e229315bbf7a..f93c65d6c7d9 100644 --- a/fs/udf/super.c +++ b/fs/udf/super.c @@ -2237,8 +2237,7 @@ static int udf_fill_super(struct super_block *sb, void *options, int silent) return 0; error_out: - if (sbi->s_vat_inode) - iput(sbi->s_vat_inode); + iput(sbi->s_vat_inode); #ifdef CONFIG_UDF_NLS if (UDF_QUERY_FLAG(sb, UDF_FLAG_NLS_MAP)) unload_nls(sbi->s_nls_map); @@ -2291,8 +2290,7 @@ static void udf_put_super(struct super_block *sb) sbi = UDF_SB(sb); - if (sbi->s_vat_inode) - iput(sbi->s_vat_inode); + iput(sbi->s_vat_inode); #ifdef CONFIG_UDF_NLS if (UDF_QUERY_FLAG(sb, UDF_FLAG_NLS_MAP)) unload_nls(sbi->s_nls_map); |