diff options
| author | Jan Kara <jack@suse.cz> | 2011-12-23 11:53:07 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-02-13 11:06:08 -0800 |
| commit | 1357ed0b4b9db30846377febb40a847d6103c991 (patch) | |
| tree | a66b70a6e261699d3fe08a6998a3a1514fd375c0 /fs/udf/super.c | |
| parent | 10f672f1a199240bc2a77d6f81e1d37f33ba743e (diff) | |
| download | lwn-1357ed0b4b9db30846377febb40a847d6103c991.tar.gz lwn-1357ed0b4b9db30846377febb40a847d6103c991.zip | |
udf: Mark LVID buffer as uptodate before marking it dirty
commit 853a0c25baf96b028de1654bea1e0c8857eadf3d upstream.
When we hit EIO while writing LVID, the buffer uptodate bit is cleared.
This then results in an anoying warning from mark_buffer_dirty() when we
write the buffer again. So just set uptodate flag unconditionally.
Reviewed-by: Namjae Jeon <linkinjeon@gmail.com>
Signed-off-by: Jan Kara <jack@suse.cz>
Cc: Dave Jones <davej@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'fs/udf/super.c')
| -rw-r--r-- | fs/udf/super.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/fs/udf/super.c b/fs/udf/super.c index 7b27b063ff6d..7f0e18aa25d4 100644 --- a/fs/udf/super.c +++ b/fs/udf/super.c @@ -1830,6 +1830,12 @@ static void udf_close_lvid(struct super_block *sb) le16_to_cpu(lvid->descTag.descCRCLength))); lvid->descTag.tagChecksum = udf_tag_checksum(&lvid->descTag); + /* + * We set buffer uptodate unconditionally here to avoid spurious + * warnings from mark_buffer_dirty() when previous EIO has marked + * the buffer as !uptodate + */ + set_buffer_uptodate(bh); mark_buffer_dirty(bh); sbi->s_lvid_dirty = 0; mutex_unlock(&sbi->s_alloc_mutex); |