diff options
| author | Eric W. Biederman <ebiederm@xmission.com> | 2009-11-04 02:50:06 -0800 |
|---|---|---|
| committer | James Morris <jmorris@namei.org> | 2009-11-05 08:19:18 +1100 |
| commit | 4c3da2209b1261af9a948b7509a38904c8eee554 (patch) | |
| tree | 74e2f113f8a40885b0df4858a3ba19f4747086a1 /fs/sysfs | |
| parent | 91d3f9bacdb4950d2f79fe2ba296aa249f60d06c (diff) | |
| download | lwn-4c3da2209b1261af9a948b7509a38904c8eee554.tar.gz lwn-4c3da2209b1261af9a948b7509a38904c8eee554.zip | |
sysfs: Don't leak secdata when a sysfs_dirent is freed.
While refreshing my sysfs patches I noticed a leak in the secdata
implementation. We don't free the secdata when we free the
sysfs dirent.
This is a bug in 2.6.32-rc5 that we really should close.
Signed-off-by: Eric W. Biederman <ebiederm@aristanetworks.com>
Acked-by: Serge Hallyn <serue@us.ibm.com>
Signed-off-by: James Morris <jmorris@namei.org>
Diffstat (limited to 'fs/sysfs')
| -rw-r--r-- | fs/sysfs/dir.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/fs/sysfs/dir.c b/fs/sysfs/dir.c index 5fad489ce5bc..e0201837d244 100644 --- a/fs/sysfs/dir.c +++ b/fs/sysfs/dir.c @@ -21,6 +21,7 @@ #include <linux/completion.h> #include <linux/mutex.h> #include <linux/slab.h> +#include <linux/security.h> #include "sysfs.h" DEFINE_MUTEX(sysfs_mutex); @@ -285,6 +286,9 @@ void release_sysfs_dirent(struct sysfs_dirent * sd) sysfs_put(sd->s_symlink.target_sd); if (sysfs_type(sd) & SYSFS_COPY_NAME) kfree(sd->s_name); + if (sd->s_iattr && sd->s_iattr->ia_secdata) + security_release_secctx(sd->s_iattr->ia_secdata, + sd->s_iattr->ia_secdata_len); kfree(sd->s_iattr); sysfs_free_ino(sd->s_ino); kmem_cache_free(sysfs_dir_cachep, sd); |