diff options
author | Joel Granados <j.granados@samsung.com> | 2023-05-23 14:22:19 +0200 |
---|---|---|
committer | Luis Chamberlain <mcgrof@kernel.org> | 2023-05-23 21:43:26 -0700 |
commit | 2f5edd03ca0d7221a88236b344b84f3fc301b1e3 (patch) | |
tree | 04f397cafa531c0767bd986edfd7ba724033aa7f /fs/sysctls.c | |
parent | 19c4e618a1bc3d0cad1f04c857be8076cb05bbb2 (diff) | |
download | lwn-2f5edd03ca0d7221a88236b344b84f3fc301b1e3.tar.gz lwn-2f5edd03ca0d7221a88236b344b84f3fc301b1e3.zip |
sysctl: Refactor base paths registrations
This is part of the general push to deprecate register_sysctl_paths and
register_sysctl_table. The old way of doing this through
register_sysctl_base and DECLARE_SYSCTL_BASE macro is replaced with a
call to register_sysctl_init. The 5 base paths affected are: "kernel",
"vm", "debug", "dev" and "fs".
We remove the register_sysctl_base function and the DECLARE_SYSCTL_BASE
macro since they are no longer needed.
In order to quickly acertain that the paths did not actually change I
executed `find /proc/sys/ | sha1sum` and made sure that the sha was the
same before and after the commit.
We end up saving 563 bytes with this change:
./scripts/bloat-o-meter vmlinux.0.base vmlinux.1.refactor-base-paths
add/remove: 0/5 grow/shrink: 2/0 up/down: 77/-640 (-563)
Function old new delta
sysctl_init_bases 55 111 +56
init_fs_sysctls 12 33 +21
vm_base_table 128 - -128
kernel_base_table 128 - -128
fs_base_table 128 - -128
dev_base_table 128 - -128
debug_base_table 128 - -128
Total: Before=21258215, After=21257652, chg -0.00%
[mcgrof: modified to use register_sysctl_init() over register_sysctl()
and add bloat-o-meter stats]
Signed-off-by: Joel Granados <j.granados@samsung.com>
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
Tested-by: Stephen Rothwell <sfr@canb.auug.org.au>
Acked-by: Christian Brauner <brauner@kernel.org>
Diffstat (limited to 'fs/sysctls.c')
-rw-r--r-- | fs/sysctls.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/fs/sysctls.c b/fs/sysctls.c index c701273c9432..76a0aee8c229 100644 --- a/fs/sysctls.c +++ b/fs/sysctls.c @@ -29,11 +29,10 @@ static struct ctl_table fs_shared_sysctls[] = { { } }; -DECLARE_SYSCTL_BASE(fs, fs_shared_sysctls); - static int __init init_fs_sysctls(void) { - return register_sysctl_base(fs); + register_sysctl_init("fs", fs_shared_sysctls); + return 0; } early_initcall(init_fs_sysctls); |