diff options
| author | Dave Kleikamp <shaggy@linux.vnet.ibm.com> | 2009-01-08 09:46:31 -0600 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2009-01-08 08:15:39 -0800 |
| commit | 96777fe7b042e5a5d0fe5fb861fcd6cd80ef9634 (patch) | |
| tree | a39a7a0a4817ec4b2815730d09a3f8b7b76a8ab2 /fs/super.c | |
| parent | 9e42d0cf5020aaf217433cad1a224745241d212a (diff) | |
| download | lwn-96777fe7b042e5a5d0fe5fb861fcd6cd80ef9634.tar.gz lwn-96777fe7b042e5a5d0fe5fb861fcd6cd80ef9634.zip | |
async: Don't call async_synchronize_full_special() while holding sb_lock
sync_filesystems() shouldn't be calling async_synchronize_full_special
while holding a spinlock. The second while loop in that function is the
right place for this anyway.
Signed-off-by: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
Cc: Arjan van de Ven <arjan@linux.intel.com>
Reported-by: Grissiom <chaos.proton@gmail.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/super.c')
| -rw-r--r-- | fs/super.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/super.c b/fs/super.c index cb20744ec789..7d67387496cb 100644 --- a/fs/super.c +++ b/fs/super.c @@ -458,7 +458,6 @@ void sync_filesystems(int wait) if (sb->s_flags & MS_RDONLY) continue; sb->s_need_sync_fs = 1; - async_synchronize_full_special(&sb->s_async_list); } restart: @@ -471,6 +470,7 @@ restart: sb->s_count++; spin_unlock(&sb_lock); down_read(&sb->s_umount); + async_synchronize_full_special(&sb->s_async_list); if (sb->s_root && (wait || sb->s_dirt)) sb->s_op->sync_fs(sb, wait); up_read(&sb->s_umount); |