diff options
| author | Geliang Tang <geliangtang@163.com> | 2015-11-07 12:43:49 +0800 |
|---|---|---|
| committer | Kees Cook <keescook@chromium.org> | 2016-06-02 11:24:52 -0700 |
| commit | 52d210d961a62a9662e27f14d6505d6741b2fb02 (patch) | |
| tree | 737ae0fafd5f5cb7bc9dd35cec60c66875ca04b5 /fs/pstore | |
| parent | 8cfc8ddc99df9509a46043b14af81f5c6a223eab (diff) | |
| download | lwn-52d210d961a62a9662e27f14d6505d6741b2fb02.tar.gz lwn-52d210d961a62a9662e27f14d6505d6741b2fb02.zip | |
pstore: drop file opened reference count
In ee1d267423a1 ("pstore: add pstore unregister") I added:
.owner = THIS_MODULE,
in both pstore_fs_type and pstore_file_operations to increase a reference
count when pstore filesystem is mounted and pstore file is opened.
But, it's repetitive. There is no need to increase the opened reference
count. We only need to increase the mounted reference count. When a file
is opened, the filesystem can't be unmounted. Hence the pstore module
can't be unloaded either.
So I drop the opened reference count in this patch.
Fixes: ee1d267423a1 ("pstore: add pstore unregister")
Signed-off-by: Geliang Tang <geliangtang@163.com>
Signed-off-by: Kees Cook <keescook@chromium.org>
Diffstat (limited to 'fs/pstore')
| -rw-r--r-- | fs/pstore/inode.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/fs/pstore/inode.c b/fs/pstore/inode.c index 45d6110744cb..ec9ddef5ae75 100644 --- a/fs/pstore/inode.c +++ b/fs/pstore/inode.c @@ -178,7 +178,6 @@ static loff_t pstore_file_llseek(struct file *file, loff_t off, int whence) } static const struct file_operations pstore_file_operations = { - .owner = THIS_MODULE, .open = pstore_file_open, .read = pstore_file_read, .llseek = pstore_file_llseek, |