summaryrefslogtreecommitdiff
path: root/fs/proc/generic.c
diff options
context:
space:
mode:
authorAlexey Dobriyan <adobriyan@gmail.com>2008-08-02 07:30:48 +0400
committerAl Viro <viro@zeniv.linux.org.uk>2008-08-25 01:18:03 -0400
commitcc996099174dc05b35b7a29301026987990e7f8c (patch)
treebfdb337167e8d33d5fd88a17503821f189485d3e /fs/proc/generic.c
parent6450f65168bcf3c03b5fb44c2fe96682c0d3086b (diff)
downloadlwn-cc996099174dc05b35b7a29301026987990e7f8c.tar.gz
lwn-cc996099174dc05b35b7a29301026987990e7f8c.zip
[PATCH] proc: inode number fixlet
Ouch, if number taken from IDA is too big, the intent was to signal an error, not check for overflow and still do overflowing addition. One still needs 2^28 proc entries to notice this. Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/proc/generic.c')
-rw-r--r--fs/proc/generic.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/proc/generic.c b/fs/proc/generic.c
index 4fb81e9c94e3..bca0f81eb687 100644
--- a/fs/proc/generic.c
+++ b/fs/proc/generic.c
@@ -330,6 +330,7 @@ retry:
spin_lock(&proc_inum_lock);
ida_remove(&proc_inum_ida, i);
spin_unlock(&proc_inum_lock);
+ return 0;
}
return PROC_DYNAMIC_FIRST + i;
}