diff options
| author | Al Viro <viro@zeniv.linux.org.uk> | 2006-05-18 08:28:02 -0400 |
|---|---|---|
| committer | Al Viro <viro@zeniv.linux.org.uk> | 2006-06-20 05:25:24 -0400 |
| commit | e0182909297da8d38a5d473ae7bee3d0324632a1 (patch) | |
| tree | 0c5c06bac1d626ba66aba1142f439b0f34c75282 /fs/proc/base.c | |
| parent | ac03221a4fdda9bfdabf99bcd129847f20fc1d80 (diff) | |
| download | lwn-e0182909297da8d38a5d473ae7bee3d0324632a1.tar.gz lwn-e0182909297da8d38a5d473ae7bee3d0324632a1.zip | |
[PATCH] proc_loginuid_write() uses simple_strtoul() on non-terminated array
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/proc/base.c')
| -rw-r--r-- | fs/proc/base.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/fs/proc/base.c b/fs/proc/base.c index 6cc77dc3f3ff..6afff725a8c9 100644 --- a/fs/proc/base.c +++ b/fs/proc/base.c @@ -1019,8 +1019,8 @@ static ssize_t proc_loginuid_write(struct file * file, const char __user * buf, if (current != task) return -EPERM; - if (count > PAGE_SIZE) - count = PAGE_SIZE; + if (count >= PAGE_SIZE) + count = PAGE_SIZE - 1; if (*ppos != 0) { /* No partial writes. */ @@ -1033,6 +1033,7 @@ static ssize_t proc_loginuid_write(struct file * file, const char __user * buf, if (copy_from_user(page, buf, count)) goto out_free_page; + page[count] = '\0'; loginuid = simple_strtoul(page, &tmp, 10); if (tmp == page) { length = -EINVAL; |