diff options
| author | Amir Goldstein <amir73il@gmail.com> | 2023-11-19 20:55:00 +0200 |
|---|---|---|
| committer | Amir Goldstein <amir73il@gmail.com> | 2023-11-20 09:49:09 +0200 |
| commit | 02d70090e0e020eff440dbe51e93fe2fc94d9835 (patch) | |
| tree | add479ba3fd8b3c9010654e24d8ae929660b2516 /fs/overlayfs/params.c | |
| parent | 98b1cc82c4affc16f5598d4fa14b1858671b2263 (diff) | |
| download | lwn-02d70090e0e020eff440dbe51e93fe2fc94d9835.tar.gz lwn-02d70090e0e020eff440dbe51e93fe2fc94d9835.zip | |
ovl: remove redundant ofs->indexdir member
When the index feature is disabled, ofs->indexdir is NULL.
When the index feature is enabled, ofs->indexdir has the same value as
ofs->workdir and takes an extra reference.
This makes the code harder to understand when it is not always clear
that ofs->indexdir in one function is the same dentry as ofs->workdir
in another function.
Remove this redundancy, by referencing ofs->workdir directly in index
helpers and by using the ovl_indexdir() accessor in generic code.
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Diffstat (limited to 'fs/overlayfs/params.c')
| -rw-r--r-- | fs/overlayfs/params.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/fs/overlayfs/params.c b/fs/overlayfs/params.c index 3fe2dde1598f..112b4b12f825 100644 --- a/fs/overlayfs/params.c +++ b/fs/overlayfs/params.c @@ -743,10 +743,8 @@ void ovl_free_fs(struct ovl_fs *ofs) unsigned i; iput(ofs->workbasedir_trap); - iput(ofs->indexdir_trap); iput(ofs->workdir_trap); dput(ofs->whiteout); - dput(ofs->indexdir); dput(ofs->workdir); if (ofs->workdir_locked) ovl_inuse_unlock(ofs->workbasedir); |