diff options
author | Mike Marshall <hubcap@omnibond.com> | 2016-11-16 11:52:19 -0500 |
---|---|---|
committer | Mike Marshall <hubcap@omnibond.com> | 2016-11-16 11:52:19 -0500 |
commit | 19ff7fcc76e6911a955742b40f85ba1030ccba5e (patch) | |
tree | 8e844e7bf2bb21b0d21e0d769e72b6243f7ef2e9 /fs/orangefs/orangefs-debugfs.c | |
parent | dc0336214eb07ee9de2a41dd4c81c744ffa419ac (diff) | |
download | lwn-19ff7fcc76e6911a955742b40f85ba1030ccba5e.tar.gz lwn-19ff7fcc76e6911a955742b40f85ba1030ccba5e.zip |
orangefs: add .owner to debugfs file_operations
Without ".owner = THIS_MODULE" it is possible to crash the kernel
by unloading the Orangefs module while someone is reading debugfs
files.
Signed-off-by: Mike Marshall <hubcap@omnibond.com>
Diffstat (limited to 'fs/orangefs/orangefs-debugfs.c')
-rw-r--r-- | fs/orangefs/orangefs-debugfs.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/orangefs/orangefs-debugfs.c b/fs/orangefs/orangefs-debugfs.c index d484068ca716..38887cc5577f 100644 --- a/fs/orangefs/orangefs-debugfs.c +++ b/fs/orangefs/orangefs-debugfs.c @@ -114,6 +114,7 @@ static const struct seq_operations help_debug_ops = { }; const struct file_operations debug_help_fops = { + .owner = THIS_MODULE, .open = orangefs_debug_help_open, .read = seq_read, .release = seq_release, @@ -121,6 +122,7 @@ const struct file_operations debug_help_fops = { }; static const struct file_operations kernel_debug_fops = { + .owner = THIS_MODULE, .open = orangefs_debug_open, .read = orangefs_debug_read, .write = orangefs_debug_write, |