diff options
| author | Alex Dewar <alex.dewar90@gmail.com> | 2020-09-14 18:57:01 +0100 |
|---|---|---|
| committer | Al Viro <viro@zeniv.linux.org.uk> | 2020-09-22 23:39:45 -0400 |
| commit | a7c9df0446d295daee68bb16c9b3746f3d21b1ef (patch) | |
| tree | 21d061d2d28749a5db1ad9a11cc9bb41c3503e39 /fs/omfs | |
| parent | 6d1349c769ea28543bdde20a658cbc93c3bc936d (diff) | |
| download | lwn-a7c9df0446d295daee68bb16c9b3746f3d21b1ef.tar.gz lwn-a7c9df0446d295daee68bb16c9b3746f3d21b1ef.zip | |
fs: omfs: use kmemdup() rather than kmalloc+memcpy
Issue identified with Coccinelle.
Signed-off-by: Alex Dewar <alex.dewar90@gmail.com>
Acked-by: Bob Copeland <me@bobcopeland.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/omfs')
| -rw-r--r-- | fs/omfs/inode.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/omfs/inode.c b/fs/omfs/inode.c index 68aa38a48308..ce93ccca8639 100644 --- a/fs/omfs/inode.c +++ b/fs/omfs/inode.c @@ -362,12 +362,11 @@ static int omfs_get_imap(struct super_block *sb) bh = sb_bread(sb, block++); if (!bh) goto nomem_free; - *ptr = kmalloc(sb->s_blocksize, GFP_KERNEL); + *ptr = kmemdup(bh->b_data, sb->s_blocksize, GFP_KERNEL); if (!*ptr) { brelse(bh); goto nomem_free; } - memcpy(*ptr, bh->b_data, sb->s_blocksize); if (count < sb->s_blocksize) memset((void *)*ptr + count, 0xff, sb->s_blocksize - count); |