summaryrefslogtreecommitdiff
path: root/fs/nfsd
diff options
context:
space:
mode:
authorYan, Zheng <zheng.z.yan@intel.com>2014-03-10 12:52:07 +0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2014-05-06 07:59:28 -0700
commit647183f379be5a197f3df3a469321de4fe532e54 (patch)
tree2806d27400b1ecec29f705843bd721be694eb012 /fs/nfsd
parent34ef215eede8f77b8f27d35096aa9e4aa149d522 (diff)
downloadlwn-647183f379be5a197f3df3a469321de4fe532e54.tar.gz
lwn-647183f379be5a197f3df3a469321de4fe532e54.zip
nfsd4: fix memory leak in nfsd4_encode_fattr()
commit 18df11d0eacf67bbcd8dda755b568bbbd7264735 upstream. fh_put() does not free the temporary file handle. Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com> Signed-off-by: J. Bruce Fields <bfields@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'fs/nfsd')
-rw-r--r--fs/nfsd/nfs4xdr.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
index d21435976a02..16e8fa71eb84 100644
--- a/fs/nfsd/nfs4xdr.c
+++ b/fs/nfsd/nfs4xdr.c
@@ -2501,8 +2501,10 @@ out:
security_release_secctx(context, contextlen);
#endif /* CONFIG_NFSD_V4_SECURITY_LABEL */
kfree(acl);
- if (tempfh)
+ if (tempfh) {
fh_put(tempfh);
+ kfree(tempfh);
+ }
return status;
out_nfserr:
status = nfserrno(err);