diff options
| author | ChenXiaoSong <chenxiaosong2@huawei.com> | 2022-06-23 09:58:58 +0800 |
|---|---|---|
| committer | Trond Myklebust <trond.myklebust@hammerspace.com> | 2022-07-12 10:05:24 -0400 |
| commit | 064109db53ecc5d88621d02f36da9f33ca0d64bd (patch) | |
| tree | 1a04b8047244e2556392a979c4494222b00fe43f /fs/nfs/file.c | |
| parent | f931d8374cad3dc09d0f6e3f76689fdb3f104c1a (diff) | |
| download | lwn-064109db53ecc5d88621d02f36da9f33ca0d64bd.tar.gz lwn-064109db53ecc5d88621d02f36da9f33ca0d64bd.zip | |
NFS: remove redundant code in nfs_file_write()
filemap_fdatawait_range() will always return 0, after patch 6c984083ec24
("NFS: Use of mapping_set_error() results in spurious errors"), it will not
save the wb err in struct address_space->flags:
result = filemap_fdatawait_range(file->f_mapping, ...) = 0
filemap_check_errors(mapping) = 0
test_bit(..., &mapping->flags) // flags is 0
Signed-off-by: ChenXiaoSong <chenxiaosong2@huawei.com>
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Diffstat (limited to 'fs/nfs/file.c')
| -rw-r--r-- | fs/nfs/file.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/fs/nfs/file.c b/fs/nfs/file.c index 2d72b1b7ed74..54237a231687 100644 --- a/fs/nfs/file.c +++ b/fs/nfs/file.c @@ -663,8 +663,6 @@ ssize_t nfs_file_write(struct kiocb *iocb, struct iov_iter *from) result = filemap_fdatawait_range(file->f_mapping, iocb->ki_pos - written, iocb->ki_pos - 1); - if (result < 0) - goto out; } result = generic_write_sync(iocb, written); if (result < 0) |