diff options
| author | Al Viro <viro@zeniv.linux.org.uk> | 2011-12-12 15:51:45 -0500 |
|---|---|---|
| committer | Al Viro <viro@zeniv.linux.org.uk> | 2012-01-03 22:52:40 -0500 |
| commit | 6b520e0565422966cdf1c3759bd73df77b0f248c (patch) | |
| tree | f63a26afa7342eb59b125271b16e30a219b59094 /fs/ncpfs | |
| parent | 2a79f17e4a641a2f463cb512cb0ec349844a147b (diff) | |
| download | lwn-6b520e0565422966cdf1c3759bd73df77b0f248c.tar.gz lwn-6b520e0565422966cdf1c3759bd73df77b0f248c.zip | |
vfs: fix the stupidity with i_dentry in inode destructors
Seeing that just about every destructor got that INIT_LIST_HEAD() copied into
it, there is no point whatsoever keeping this INIT_LIST_HEAD in inode_init_once();
the cost of taking it into inode_init_always() will be negligible for pipes
and sockets and negative for everything else. Not to mention the removal of
boilerplate code from ->destroy_inode() instances...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/ncpfs')
| -rw-r--r-- | fs/ncpfs/inode.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/fs/ncpfs/inode.c b/fs/ncpfs/inode.c index cbd1a61c110a..f3f07cd392b3 100644 --- a/fs/ncpfs/inode.c +++ b/fs/ncpfs/inode.c @@ -60,7 +60,6 @@ static struct inode *ncp_alloc_inode(struct super_block *sb) static void ncp_i_callback(struct rcu_head *head) { struct inode *inode = container_of(head, struct inode, i_rcu); - INIT_LIST_HEAD(&inode->i_dentry); kmem_cache_free(ncp_inode_cachep, NCP_FINFO(inode)); } |