diff options
| author | Nick Piggin <npiggin@kernel.dk> | 2011-01-07 17:49:43 +1100 |
|---|---|---|
| committer | Nick Piggin <npiggin@kernel.dk> | 2011-01-07 17:50:24 +1100 |
| commit | dc0474be3e27463d4d4a2793f82366eed906f223 (patch) | |
| tree | 41f75e638442cb343bacdcfbabb17ffc3bd5b4ce /fs/ncpfs | |
| parent | 357f8e658bba8a085c4a5d4331e30894be8096b8 (diff) | |
| download | lwn-dc0474be3e27463d4d4a2793f82366eed906f223.tar.gz lwn-dc0474be3e27463d4d4a2793f82366eed906f223.zip | |
fs: dcache rationalise dget variants
dget_locked was a shortcut to avoid the lazy lru manipulation when we already
held dcache_lock (lru manipulation was relatively cheap at that point).
However, how that the lru lock is an innermost one, we never hold it at any
caller, so the lock cost can now be avoided. We already have well working lazy
dcache LRU, so it should be fine to defer LRU manipulations to scan time.
Signed-off-by: Nick Piggin <npiggin@kernel.dk>
Diffstat (limited to 'fs/ncpfs')
| -rw-r--r-- | fs/ncpfs/dir.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/ncpfs/dir.c b/fs/ncpfs/dir.c index de15c533311c..0ba3cdc95a44 100644 --- a/fs/ncpfs/dir.c +++ b/fs/ncpfs/dir.c @@ -397,7 +397,7 @@ ncp_dget_fpos(struct dentry *dentry, struct dentry *parent, unsigned long fpos) dent = list_entry(next, struct dentry, d_u.d_child); if ((unsigned long)dent->d_fsdata == fpos) { if (dent->d_inode) - dget_locked(dent); + dget(dent); else dent = NULL; spin_unlock(&parent->d_lock); |