diff options
| author | Andreas Gruenbacher <agruen@kernel.org> | 2011-10-23 23:13:33 +0530 |
|---|---|---|
| committer | root <root@serles.lst.de> | 2011-10-28 14:58:55 +0200 |
| commit | 948409c74d217f6cf054b8c927765a1c3fe16b53 (patch) | |
| tree | e4d0d3d07eb8f11333fd050e3d577834da600db5 /fs/namei.c | |
| parent | d124b60a838141bb9cac1b6567e9ca4539d1fff0 (diff) | |
| download | lwn-948409c74d217f6cf054b8c927765a1c3fe16b53.tar.gz lwn-948409c74d217f6cf054b8c927765a1c3fe16b53.zip | |
vfs: add a comment to inode_permission()
Acked-by: J. Bruce Fields <bfields@redhat.com>
Acked-by: David Howells <dhowells@redhat.com>
Signed-off-by: Andreas Gruenbacher <agruen@kernel.org>
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'fs/namei.c')
| -rw-r--r-- | fs/namei.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/fs/namei.c b/fs/namei.c index 276cd30ab8f8..9061157e39d6 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -221,7 +221,7 @@ static int check_acl(struct inode *inode, int mask) } /* - * This does basic POSIX ACL permission checking + * This does the basic permission checking */ static int acl_permission_check(struct inode *inode, int mask) { @@ -271,7 +271,7 @@ int generic_permission(struct inode *inode, int mask) int ret; /* - * Do the basic POSIX ACL permission checks. + * Do the basic permission checks. */ ret = acl_permission_check(inode, mask); if (ret != -EACCES) @@ -335,6 +335,8 @@ static inline int do_inode_permission(struct inode *inode, int mask) * We use "fsuid" for this, letting us set arbitrary permissions * for filesystem access without changing the "normal" uids which * are used for other things. + * + * When checking for MAY_APPEND, MAY_WRITE must also be set in @mask. */ int inode_permission(struct inode *inode, int mask) { |