diff options
| author | Jan Kara <jack@suse.cz> | 2017-02-01 09:21:58 +0100 |
|---|---|---|
| committer | Jan Kara <jack@suse.cz> | 2017-04-10 17:37:35 +0200 |
| commit | 08991e83b7286635167bab40927665a90fb00d81 (patch) | |
| tree | e82e62c0a92193ff3af83d3d1ea60f0430c5c118 /fs/mount.h | |
| parent | 04662cab59fc3e8421fd7a0539d304d51d2750a4 (diff) | |
| download | lwn-08991e83b7286635167bab40927665a90fb00d81.tar.gz lwn-08991e83b7286635167bab40927665a90fb00d81.zip | |
fsnotify: Free fsnotify_mark_connector when there is no mark attached
Currently we free fsnotify_mark_connector structure only when inode /
vfsmount is getting freed. This can however impose noticeable memory
overhead when marks get attached to inodes only temporarily. So free the
connector structure once the last mark is detached from the object.
Since notification infrastructure can be working with the connector
under the protection of fsnotify_mark_srcu, we have to be careful and
free the fsnotify_mark_connector only after SRCU period passes.
Reviewed-by: Miklos Szeredi <mszeredi@redhat.com>
Reviewed-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Jan Kara <jack@suse.cz>
Diffstat (limited to 'fs/mount.h')
| -rw-r--r-- | fs/mount.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/mount.h b/fs/mount.h index bc409360a03b..bf1fda6eed8f 100644 --- a/fs/mount.h +++ b/fs/mount.h @@ -59,7 +59,7 @@ struct mount { struct mountpoint *mnt_mp; /* where is it mounted */ struct hlist_node mnt_mp_list; /* list mounts with the same mountpoint */ #ifdef CONFIG_FSNOTIFY - struct fsnotify_mark_connector *mnt_fsnotify_marks; + struct fsnotify_mark_connector __rcu *mnt_fsnotify_marks; __u32 mnt_fsnotify_mask; #endif int mnt_id; /* mount identifier */ |