diff options
| author | Al Viro <viro@ZenIV.linux.org.uk> | 2011-06-05 19:22:56 +0100 |
|---|---|---|
| committer | Al Viro <viro@zeniv.linux.org.uk> | 2011-06-07 08:50:59 -0400 |
| commit | 9054760ff585a7fa436599990b63a585ae89ff4d (patch) | |
| tree | 3afdd2d1f7d80d75e19a2ab19358024f23c529e4 /fs/jfs | |
| parent | 3ece48a746088be3dd75904e8d9bb9b49af0aa95 (diff) | |
| download | lwn-9054760ff585a7fa436599990b63a585ae89ff4d.tar.gz lwn-9054760ff585a7fa436599990b63a585ae89ff4d.zip | |
lmLogOpen() broken failure exit
Callers of lmLogOpen() expect it to return -E... on failure exits, which
is what it returns, except for the case of blkdev_get_by_dev() failure.
It that case lmLogOpen() return the error with the wrong sign...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Acked-by: Dave Kleikamp <dave.kleikamp@oracle.com>
Diffstat (limited to 'fs/jfs')
| -rw-r--r-- | fs/jfs/jfs_logmgr.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/jfs/jfs_logmgr.c b/fs/jfs/jfs_logmgr.c index 278e3fb40b71..583636f745e5 100644 --- a/fs/jfs/jfs_logmgr.c +++ b/fs/jfs/jfs_logmgr.c @@ -1123,7 +1123,7 @@ int lmLogOpen(struct super_block *sb) bdev = blkdev_get_by_dev(sbi->logdev, FMODE_READ|FMODE_WRITE|FMODE_EXCL, log); if (IS_ERR(bdev)) { - rc = -PTR_ERR(bdev); + rc = PTR_ERR(bdev); goto free; } |