diff options
| author | Jens Axboe <axboe@kernel.dk> | 2021-02-23 19:17:35 -0700 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2021-02-23 19:18:13 -0700 |
| commit | 7c977a58dc83366e488c217fd88b1469d242bee5 (patch) | |
| tree | 54174fc5f340870547021faa82a4f89df9a803da /fs/io_uring.c | |
| parent | 8e5c66c485a8af3f39a8b0358e9e09f002016d92 (diff) | |
| download | lwn-7c977a58dc83366e488c217fd88b1469d242bee5.tar.gz lwn-7c977a58dc83366e488c217fd88b1469d242bee5.zip | |
io_uring: don't attempt IO reissue from the ring exit path
If we're exiting the ring, just let the IO fail with -EAGAIN as nobody
will care anyway. It's not the right context to reissue from.
Cc: stable@vger.kernel.org
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'fs/io_uring.c')
| -rw-r--r-- | fs/io_uring.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/fs/io_uring.c b/fs/io_uring.c index bf9ad810c621..275ad84e8227 100644 --- a/fs/io_uring.c +++ b/fs/io_uring.c @@ -2839,6 +2839,13 @@ static bool io_rw_reissue(struct io_kiocb *req) return false; if ((req->flags & REQ_F_NOWAIT) || io_wq_current_is_worker()) return false; + /* + * If ref is dying, we might be running poll reap from the exit work. + * Don't attempt to reissue from that path, just let it fail with + * -EAGAIN. + */ + if (percpu_ref_is_dying(&req->ctx->refs)) + return false; lockdep_assert_held(&req->ctx->uring_lock); |