diff options
| author | Jens Axboe <axboe@kernel.dk> | 2020-10-13 15:01:40 -0600 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2020-10-17 09:25:43 -0600 |
| commit | 0918682be432b85ccd49285832221d9b65831ef5 (patch) | |
| tree | d64954b5c85de1898e6dccb685b5efc41b2120f9 /fs/io_uring.c | |
| parent | 216578e55ac932cf5e348d9e65d8e129fc9e34cc (diff) | |
| download | lwn-0918682be432b85ccd49285832221d9b65831ef5.tar.gz lwn-0918682be432b85ccd49285832221d9b65831ef5.zip | |
Revert "io_uring: mark io_uring_fops/io_op_defs as __read_mostly"
This reverts commit 738277adc81929b3e7c9b63fec6693868cc5f931.
This change didn't make a lot of sense, and as Linus reports, it actually
fails on clang:
/tmp/io_uring-dd40c4.s:26476: Warning: ignoring changed section
attributes for .data..read_mostly
The arrays are already marked const so, by definition, they are not
just read-mostly, they are read-only.
Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'fs/io_uring.c')
| -rw-r--r-- | fs/io_uring.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/io_uring.c b/fs/io_uring.c index 641d869d96ee..94a66a6d1cba 100644 --- a/fs/io_uring.c +++ b/fs/io_uring.c @@ -760,7 +760,7 @@ struct io_op_def { unsigned short async_size; }; -static const struct io_op_def io_op_defs[] __read_mostly = { +static const struct io_op_def io_op_defs[] = { [IORING_OP_NOP] = {}, [IORING_OP_READV] = { .needs_mm = 1, @@ -983,7 +983,7 @@ static int io_setup_async_rw(struct io_kiocb *req, const struct iovec *iovec, static struct kmem_cache *req_cachep; -static const struct file_operations io_uring_fops __read_mostly; +static const struct file_operations io_uring_fops; struct sock *io_uring_get_socket(struct file *file) { |