diff options
author | Jens Axboe <axboe@kernel.dk> | 2021-03-08 09:37:51 -0700 |
---|---|---|
committer | Jens Axboe <axboe@kernel.dk> | 2021-04-11 17:42:00 -0600 |
commit | 685fe7feedb96771683437107ba72131410e2350 (patch) | |
tree | 8819f9e785293f0ef4d2a4b87888bcf755660305 /fs/io-wq.h | |
parent | 66ae0d1e2d9fe6ec70e73fcfdcf4b390e271c1ac (diff) | |
download | lwn-685fe7feedb96771683437107ba72131410e2350.tar.gz lwn-685fe7feedb96771683437107ba72131410e2350.zip |
io-wq: eliminate the need for a manager thread
io-wq relies on a manager thread to create/fork new workers, as needed.
But there's really no strong need for it anymore. We have the following
cases that fork a new worker:
1) Work queue. This is done from the task itself always, and it's trivial
to create a worker off that path, if needed.
2) All workers have gone to sleep, and we have more work. This is called
off the sched out path. For this case, use a task_work items to queue
a fork-worker operation.
3) Hashed work completion. Don't think we need to do anything off this
case. If need be, it could just use approach 2 as well.
Part of this change is incrementing the running worker count before the
fork, to avoid cases where we observe we need a worker and then queue
creation of one. Then new work comes in, we fork a new one. That last
queue operation should have waited for the previous worker to come up,
it's quite possible we don't even need it. Hence move the worker running
from before we fork it off to more efficiently handle that case.
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'fs/io-wq.h')
-rw-r--r-- | fs/io-wq.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/io-wq.h b/fs/io-wq.h index 80d590564ff9..0e6d310999e8 100644 --- a/fs/io-wq.h +++ b/fs/io-wq.h @@ -116,6 +116,7 @@ static inline void io_wq_put_hash(struct io_wq_hash *hash) struct io_wq_data { struct io_wq_hash *hash; + struct task_struct *task; io_wq_work_fn *do_work; free_work_fn *free_work; }; |