diff options
author | Namhyung Kim <namhyung@gmail.com> | 2010-10-11 22:38:00 +0900 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2010-10-25 21:18:23 -0400 |
commit | a3314a0ed389f51a51695120b429eccd45b3a165 (patch) | |
tree | bf8ce1231099e372dd25dc71d467831beaaccff7 /fs/inode.c | |
parent | 306fb0979443419288594446a348155a8027dcf2 (diff) | |
download | lwn-a3314a0ed389f51a51695120b429eccd45b3a165.tar.gz lwn-a3314a0ed389f51a51695120b429eccd45b3a165.zip |
lockdep: fixup checking of dir inode annotation
Since inode->i_mode shares its bits for S_IFMT, S_ISDIR should be
used to distinguish whether it is a dir or not.
Signed-off-by: Namhyung Kim <namhyung@gmail.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/inode.c')
-rw-r--r-- | fs/inode.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/inode.c b/fs/inode.c index 3368abd64bb5..4f0a67c54f89 100644 --- a/fs/inode.c +++ b/fs/inode.c @@ -663,7 +663,7 @@ EXPORT_SYMBOL(new_inode); void unlock_new_inode(struct inode *inode) { #ifdef CONFIG_DEBUG_LOCK_ALLOC - if (inode->i_mode & S_IFDIR) { + if (S_ISDIR(inode->i_mode)) { struct file_system_type *type = inode->i_sb->s_type; /* Set new key only if filesystem hasn't already changed it */ |