diff options
| author | Al Viro <viro@zeniv.linux.org.uk> | 2011-06-20 19:16:29 -0400 |
|---|---|---|
| committer | Al Viro <viro@zeniv.linux.org.uk> | 2011-07-20 01:43:22 -0400 |
| commit | 2830ba7f34ebb27c4e5b8b6ef408cd6d74860890 (patch) | |
| tree | bbcebc14bffd000f1dfcbf37e64f56d2f49581ac /fs/hpfs | |
| parent | 7e40145eb111a5192e6d819f764db9d6828d1abb (diff) | |
| download | lwn-2830ba7f34ebb27c4e5b8b6ef408cd6d74860890.tar.gz lwn-2830ba7f34ebb27c4e5b8b6ef408cd6d74860890.zip | |
->permission() sanitizing: don't pass flags to generic_permission()
redundant; all callers get it duplicated in mask & MAY_NOT_BLOCK and none of
them removes that bit.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/hpfs')
| -rw-r--r-- | fs/hpfs/namei.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/hpfs/namei.c b/fs/hpfs/namei.c index bd2ce7dd8df3..2df69e2f07cf 100644 --- a/fs/hpfs/namei.c +++ b/fs/hpfs/namei.c @@ -398,7 +398,7 @@ again: hpfs_unlock(dir->i_sb); return -ENOSPC; } - if (generic_permission(inode, MAY_WRITE, 0) || + if (generic_permission(inode, MAY_WRITE) || !S_ISREG(inode->i_mode) || get_write_access(inode)) { d_rehash(dentry); |