diff options
| author | Alexey Dobriyan <adobriyan@gmail.com> | 2006-09-27 01:49:40 -0700 |
|---|---|---|
| committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-09-27 08:26:10 -0700 |
| commit | 1a1d92c10dd24bbdc28b3d6e2d03ec199dd3a65b (patch) | |
| tree | fade83955f75e718e39153d6f81d221403338bed /fs/hfs/super.c | |
| parent | f52720ca5f48574e347dff35ffe6b389ace61537 (diff) | |
| download | lwn-1a1d92c10dd24bbdc28b3d6e2d03ec199dd3a65b.tar.gz lwn-1a1d92c10dd24bbdc28b3d6e2d03ec199dd3a65b.zip | |
[PATCH] Really ignore kmem_cache_destroy return value
* Rougly half of callers already do it by not checking return value
* Code in drivers/acpi/osl.c does the following to be sure:
(void)kmem_cache_destroy(cache);
* Those who check it printk something, however, slab_error already printed
the name of failed cache.
* XFS BUGs on failed kmem_cache_destroy which is not the decision
low-level filesystem driver should make. Converted to ignore.
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'fs/hfs/super.c')
| -rw-r--r-- | fs/hfs/super.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/hfs/super.c b/fs/hfs/super.c index 05dffff1a372..d43b4fcc8ad3 100644 --- a/fs/hfs/super.c +++ b/fs/hfs/super.c @@ -454,8 +454,7 @@ static int __init init_hfs_fs(void) static void __exit exit_hfs_fs(void) { unregister_filesystem(&hfs_fs_type); - if (kmem_cache_destroy(hfs_inode_cachep)) - printk(KERN_ERR "hfs_inode_cache: not all structures were freed\n"); + kmem_cache_destroy(hfs_inode_cachep); } module_init(init_hfs_fs) |