diff options
| author | Alexey Khoroshilov <khoroshilov@ispras.ru> | 2013-06-06 01:29:04 +0400 |
|---|---|---|
| committer | Steven Whitehouse <swhiteho@redhat.com> | 2013-06-06 09:52:29 +0100 |
| commit | a9aefd707c65aa5a7945b3f16bd39f314aa8414d (patch) | |
| tree | 5a41e8c469b5d396de1c48627873ce163c53fce6 /fs/gfs2 | |
| parent | edd2e9acc06f1f32ce9acab442d395bacc6c8d7f (diff) | |
| download | lwn-a9aefd707c65aa5a7945b3f16bd39f314aa8414d.tar.gz lwn-a9aefd707c65aa5a7945b3f16bd39f314aa8414d.zip | |
GFS2: fix error propagation in init_threads()
If kthread_run() fails, init_threads() returns
IS_ERR(p) instead of PTR_ERR(p).
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
Diffstat (limited to 'fs/gfs2')
| -rw-r--r-- | fs/gfs2/ops_fstype.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c index 60ede2a0f43f..0262c190b6f9 100644 --- a/fs/gfs2/ops_fstype.c +++ b/fs/gfs2/ops_fstype.c @@ -916,16 +916,16 @@ static int init_threads(struct gfs2_sbd *sdp, int undo) goto fail_quotad; p = kthread_run(gfs2_logd, sdp, "gfs2_logd"); - error = IS_ERR(p); - if (error) { + if (IS_ERR(p)) { + error = PTR_ERR(p); fs_err(sdp, "can't start logd thread: %d\n", error); return error; } sdp->sd_logd_process = p; p = kthread_run(gfs2_quotad, sdp, "gfs2_quotad"); - error = IS_ERR(p); - if (error) { + if (IS_ERR(p)) { + error = PTR_ERR(p); fs_err(sdp, "can't start quotad thread: %d\n", error); goto fail; } |