summaryrefslogtreecommitdiff
path: root/fs/gfs2
diff options
context:
space:
mode:
authorSteven Whitehouse <swhiteho@redhat.com>2006-04-24 13:13:56 -0400
committerSteven Whitehouse <swhiteho@redhat.com>2006-04-24 13:13:56 -0400
commitb800a1cb3940f216c4e5c963007a1f72fca0f15f (patch)
treee84f378c693e4e61de91f40af31ee24dafce3295 /fs/gfs2
parent61e085a88cb59232eb8ff5b446d70491c7bf2c68 (diff)
downloadlwn-b800a1cb3940f216c4e5c963007a1f72fca0f15f.tar.gz
lwn-b800a1cb3940f216c4e5c963007a1f72fca0f15f.zip
[GFS2] Tidy up daemon.c
As per Andrew Morton's comments, remove uneeded casts and use wait_event_interruptible() rather than open code the wait. Cc: Andrew Morton <akpm@osdl.org> Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
Diffstat (limited to 'fs/gfs2')
-rw-r--r--fs/gfs2/daemon.c23
1 files changed, 9 insertions, 14 deletions
diff --git a/fs/gfs2/daemon.c b/fs/gfs2/daemon.c
index b3830b92d78c..c2b5d69044c6 100644
--- a/fs/gfs2/daemon.c
+++ b/fs/gfs2/daemon.c
@@ -45,7 +45,7 @@
int gfs2_scand(void *data)
{
- struct gfs2_sbd *sdp = (struct gfs2_sbd *)data;
+ struct gfs2_sbd *sdp = data;
unsigned long t;
while (!kthread_should_stop()) {
@@ -67,20 +67,15 @@ int gfs2_scand(void *data)
int gfs2_glockd(void *data)
{
- struct gfs2_sbd *sdp = (struct gfs2_sbd *)data;
- DECLARE_WAITQUEUE(wait_chan, current);
+ struct gfs2_sbd *sdp = data;
while (!kthread_should_stop()) {
while (atomic_read(&sdp->sd_reclaim_count))
gfs2_reclaim_glock(sdp);
- set_current_state(TASK_INTERRUPTIBLE);
- add_wait_queue(&sdp->sd_reclaim_wq, &wait_chan);
- if (!atomic_read(&sdp->sd_reclaim_count) &&
- !kthread_should_stop())
- schedule();
- remove_wait_queue(&sdp->sd_reclaim_wq, &wait_chan);
- set_current_state(TASK_RUNNING);
+ wait_event_interruptible(sdp->sd_reclaim_wq,
+ (atomic_read(&sdp->sd_reclaim_count) ||
+ kthread_should_stop()));
}
return 0;
@@ -94,7 +89,7 @@ int gfs2_glockd(void *data)
int gfs2_recoverd(void *data)
{
- struct gfs2_sbd *sdp = (struct gfs2_sbd *)data;
+ struct gfs2_sbd *sdp = data;
unsigned long t;
while (!kthread_should_stop()) {
@@ -116,7 +111,7 @@ int gfs2_recoverd(void *data)
int gfs2_logd(void *data)
{
- struct gfs2_sbd *sdp = (struct gfs2_sbd *)data;
+ struct gfs2_sbd *sdp = data;
struct gfs2_holder ji_gh;
unsigned long t;
@@ -159,7 +154,7 @@ int gfs2_logd(void *data)
int gfs2_quotad(void *data)
{
- struct gfs2_sbd *sdp = (struct gfs2_sbd *)data;
+ struct gfs2_sbd *sdp = data;
unsigned long t;
int error;
@@ -209,7 +204,7 @@ int gfs2_quotad(void *data)
int gfs2_inoded(void *data)
{
- struct gfs2_sbd *sdp = (struct gfs2_sbd *)data;
+ struct gfs2_sbd *sdp = data;
unsigned long t;
int error;