diff options
| author | Andreas Gruenbacher <agruenba@redhat.com> | 2016-06-17 07:31:27 -0500 |
|---|---|---|
| committer | Bob Peterson <rpeterso@redhat.com> | 2016-06-27 09:47:09 -0500 |
| commit | 6df9f9a253c7dc9f8ed18bf89d762de350a31813 (patch) | |
| tree | a048f6fb09f9da9d1616b7f5a9c9254ce6f1d7ab /fs/gfs2/quota.c | |
| parent | cda9dd4207aeb29d0aa2298085cc2d1ebcb87e04 (diff) | |
| download | lwn-6df9f9a253c7dc9f8ed18bf89d762de350a31813.tar.gz lwn-6df9f9a253c7dc9f8ed18bf89d762de350a31813.zip | |
gfs2: Lock holder cleanup
Make the code more readable by cleaning up the different ways of
initializing lock holders and checking for initialized lock holders:
mark lock holders as uninitialized by setting the holder's glock to NULL
(gfs2_holder_mark_uninitialized) instead of zeroing out the entire
object or using a separate flag. Recognize initialized holders by their
non-NULL glock (gfs2_holder_initialized). Don't zero out holder objects
which are immeditiately initialized via gfs2_holder_init or
gfs2_glock_nq_init.
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
Signed-off-by: Bob Peterson <rpeterso@redhat.com>
Diffstat (limited to 'fs/gfs2/quota.c')
| -rw-r--r-- | fs/gfs2/quota.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/gfs2/quota.c b/fs/gfs2/quota.c index ce7d69a2fdc0..6c657b202501 100644 --- a/fs/gfs2/quota.c +++ b/fs/gfs2/quota.c @@ -883,7 +883,7 @@ static int do_sync(unsigned int num_qd, struct gfs2_quota_data **qda) gfs2_write_calc_reserv(ip, sizeof(struct gfs2_quota), &data_blocks, &ind_blocks); - ghs = kcalloc(num_qd, sizeof(struct gfs2_holder), GFP_NOFS); + ghs = kmalloc(num_qd * sizeof(struct gfs2_holder), GFP_NOFS); if (!ghs) return -ENOMEM; |