diff options
| author | Steven Whitehouse <swhiteho@redhat.com> | 2007-10-15 16:29:05 +0100 |
|---|---|---|
| committer | Steven Whitehouse <swhiteho@redhat.com> | 2008-01-25 08:07:16 +0000 |
| commit | f91a0d3e24e4b0198be5fae20d45a35c40d1efce (patch) | |
| tree | cda8095f9befd25cbfaf5f63a4c8ca26870d45ca /fs/gfs2/main.c | |
| parent | 3cc3f710ce0effe397b830826a1a081fa81f11c7 (diff) | |
| download | lwn-f91a0d3e24e4b0198be5fae20d45a35c40d1efce.tar.gz lwn-f91a0d3e24e4b0198be5fae20d45a35c40d1efce.zip | |
[GFS2] Remove useless i_cache from inodes
The i_cache was designed to keep references to the indirect blocks
used during block mapping so that they didn't have to be looked
up continually. The idea failed because there are too many places
where the i_cache needs to be freed, and this has in the past been
the cause of many bugs.
In addition there was no performance benefit being gained since the
disk blocks in question were cached anyway. So this patch removes
it in order to simplify the code to prepare for other changes which
would otherwise have had to add further support for this feature.
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
Diffstat (limited to 'fs/gfs2/main.c')
| -rw-r--r-- | fs/gfs2/main.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/fs/gfs2/main.c b/fs/gfs2/main.c index 7ecfe0d3a491..653fd5a6203a 100644 --- a/fs/gfs2/main.c +++ b/fs/gfs2/main.c @@ -31,7 +31,6 @@ static void gfs2_init_inode_once(struct kmem_cache *cachep, void *foo) inode_init_once(&ip->i_inode); spin_lock_init(&ip->i_spin); init_rwsem(&ip->i_rw_mutex); - memset(ip->i_cache, 0, sizeof(ip->i_cache)); } static void gfs2_init_glock_once(struct kmem_cache *cachep, void *foo) |