diff options
| author | Steven Whitehouse <swhiteho@redhat.com> | 2006-09-04 11:41:31 -0400 |
|---|---|---|
| committer | Steven Whitehouse <swhiteho@redhat.com> | 2006-09-04 11:41:31 -0400 |
| commit | 75d3b817a0b48425da921052955cc58f20bbab52 (patch) | |
| tree | 7fb2e9bf18d794a590f43397ee56f3ce917a2233 /fs/gfs2/glops.c | |
| parent | 31e77ac55f18db0ec1c724840927562ef3093ef6 (diff) | |
| download | lwn-75d3b817a0b48425da921052955cc58f20bbab52.tar.gz lwn-75d3b817a0b48425da921052955cc58f20bbab52.zip | |
[GFS2] Tidy up bmap/inode code
As per Jan Engelhardt's third set of comments, this make various
code style changes and moves the structures from format.h into
super.c, which was the only place that format.h was actually used.
Cc: Jan Engelhardt <jengelh@linux01.gwdg.de>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
Diffstat (limited to 'fs/gfs2/glops.c')
| -rw-r--r-- | fs/gfs2/glops.c | 12 |
1 files changed, 5 insertions, 7 deletions
diff --git a/fs/gfs2/glops.c b/fs/gfs2/glops.c index 8e1d8ee68e2e..d3e7b082a918 100644 --- a/fs/gfs2/glops.c +++ b/fs/gfs2/glops.c @@ -234,7 +234,6 @@ static void inode_go_sync(struct gfs2_glock *gl, int flags) if (flags & DIO_RELEASE) gfs2_ail_empty_gl(gl); } - } /** @@ -324,12 +323,11 @@ static void inode_go_unlock(struct gfs2_holder *gh) struct gfs2_glock *gl = gh->gh_gl; struct gfs2_inode *ip = gl->gl_object; - if (ip) { - if (test_bit(GLF_DIRTY, &gl->gl_flags)) - gfs2_inode_attr_in(ip); - - gfs2_meta_cache_flush(ip); - } + if (ip == NULL) + return; + if (test_bit(GLF_DIRTY, &gl->gl_flags)) + gfs2_inode_attr_in(ip); + gfs2_meta_cache_flush(ip); } /** |