diff options
| author | Vivek Goyal <vgoyal@redhat.com> | 2019-03-06 16:51:40 -0500 |
|---|---|---|
| committer | Miklos Szeredi <mszeredi@redhat.com> | 2019-09-12 14:59:41 +0200 |
| commit | 0cd1eb9a4160a96e0ec9b93b2e7b489f449bf22d (patch) | |
| tree | 54ff7b7366dafb376d6a94bed28a86358c6b2023 /fs/fuse/dev.c | |
| parent | ae3aad77f46fbba56eff7141b2fc49870b60827e (diff) | |
| download | lwn-0cd1eb9a4160a96e0ec9b93b2e7b489f449bf22d.tar.gz lwn-0cd1eb9a4160a96e0ec9b93b2e7b489f449bf22d.zip | |
fuse: separate fuse device allocation and installation in fuse_conn
As of now fuse_dev_alloc() both allocates a fuse device and installs it in
fuse_conn list. fuse_dev_alloc() can fail if fuse_device allocation fails.
virtio-fs needs to initialize multiple fuse devices (one per virtio queue).
It initializes one fuse device as part of call to fuse_fill_super_common()
and rest of the devices are allocated and installed after that.
But, we can't afford to fail after calling fuse_fill_super_common() as we
don't have a way to undo all the actions done by fuse_fill_super_common().
So to avoid failures after the call to fuse_fill_super_common(),
pre-allocate all fuse devices early and install them into fuse connection
later.
This patch provides two separate helpers for fuse device allocation and
fuse device installation in fuse_conn.
Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Diffstat (limited to 'fs/fuse/dev.c')
| -rw-r--r-- | fs/fuse/dev.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/fuse/dev.c b/fs/fuse/dev.c index 358a01435058..b2e18861c59c 100644 --- a/fs/fuse/dev.c +++ b/fs/fuse/dev.c @@ -2203,7 +2203,7 @@ static int fuse_device_clone(struct fuse_conn *fc, struct file *new) if (new->private_data) return -EINVAL; - fud = fuse_dev_alloc(fc); + fud = fuse_dev_alloc_install(fc); if (!fud) return -ENOMEM; |