diff options
| author | David Howells <dhowells@redhat.com> | 2012-12-20 21:52:33 +0000 |
|---|---|---|
| committer | David Howells <dhowells@redhat.com> | 2012-12-20 21:58:25 +0000 |
| commit | 0f972b5696c0a0677a9b3a18fee45cc0e8de4184 (patch) | |
| tree | 3cde9016353e20e4c52cc01a652bb87461809520 /fs/fscache | |
| parent | 5f4f9f4af185d5e76c966d2d3420a61870c856e7 (diff) | |
| download | lwn-0f972b5696c0a0677a9b3a18fee45cc0e8de4184.tar.gz lwn-0f972b5696c0a0677a9b3a18fee45cc0e8de4184.zip | |
FS-Cache: Check that there are no read ops when cookie relinquished
Check that the netfs isn't trying to relinquish a cookie that still has read
operations in progress upon it. If there are, then give log a warning and BUG.
Signed-off-by: David Howells <dhowells@redhat.com>
Diffstat (limited to 'fs/fscache')
| -rw-r--r-- | fs/fscache/cookie.c | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/fs/fscache/cookie.c b/fs/fscache/cookie.c index 990535071a8a..0666996adf80 100644 --- a/fs/fscache/cookie.c +++ b/fs/fscache/cookie.c @@ -452,6 +452,14 @@ void __fscache_relinquish_cookie(struct fscache_cookie *cookie, int retire) _debug("RELEASE OBJ%x", object->debug_id); + if (atomic_read(&object->n_reads)) { + spin_unlock(&cookie->lock); + printk(KERN_ERR "FS-Cache:" + " Cookie '%s' still has %d outstanding reads\n", + cookie->def->name, atomic_read(&object->n_reads)); + BUG(); + } + /* detach each cache object from the object cookie */ spin_lock(&object->lock); hlist_del_init(&object->cookie_link); |