diff options
author | Ilya Dryomov <idryomov@gmail.com> | 2016-05-30 18:33:32 +0200 |
---|---|---|
committer | Ilya Dryomov <idryomov@gmail.com> | 2016-05-30 23:00:23 +0200 |
commit | 4a3262b17c96b6ff332134c9e57f193a20226eb2 (patch) | |
tree | 4cfeba3d5e7f6db9031edf3859ed36c2045685e6 /fs/fscache/page.c | |
parent | dc045a9168c83b2dc590930a0565e066346de382 (diff) | |
download | lwn-4a3262b17c96b6ff332134c9e57f193a20226eb2.tar.gz lwn-4a3262b17c96b6ff332134c9e57f193a20226eb2.zip |
libceph: use %s instead of %pE in dout()s
Commit d30291b985d1 ("libceph: variable-sized ceph_object_id") changed
dout()s in what is now encode_request() and ceph_object_locator_to_pg()
to use %pE, mostly to document that, although all rbd and cephfs object
names are NULL-terminated strings, ceph_object_id will handle any RADOS
object name, including the one containing NULs, just fine.
However, it turns out that vbin_printf() can't handle anything but ints
and %s - all %p suffixes are ignored. The buffer %p** points to isn't
recorded, resulting in trash in the messages if the buffer had been
reused by the time bstr_printf() got to it.
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Diffstat (limited to 'fs/fscache/page.c')
0 files changed, 0 insertions, 0 deletions