diff options
| author | Eric Biggers <ebiggers@google.com> | 2021-01-12 11:02:50 -0800 |
|---|---|---|
| committer | Jan Kara <jack@suse.cz> | 2021-01-13 17:26:45 +0100 |
| commit | 83dc881d678a8e973212afa0c5e4fb2fe1b06d4e (patch) | |
| tree | 4257861433f6099f70a06f53b27866220a9bf66d /fs/fs-writeback.c | |
| parent | 35d14f278e530ecb635ab00de984065ed90ee12f (diff) | |
| download | lwn-83dc881d678a8e973212afa0c5e4fb2fe1b06d4e.tar.gz lwn-83dc881d678a8e973212afa0c5e4fb2fe1b06d4e.zip | |
fs: drop redundant check from __writeback_single_inode()
wbc->for_sync implies wbc->sync_mode == WB_SYNC_ALL, so there's no need
to check for both. Just check for WB_SYNC_ALL.
Link: https://lore.kernel.org/r/20210112190253.64307-9-ebiggers@kernel.org
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Jan Kara <jack@suse.cz>
Diffstat (limited to 'fs/fs-writeback.c')
| -rw-r--r-- | fs/fs-writeback.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c index 80ee9816d9df..cee1df6e3bd4 100644 --- a/fs/fs-writeback.c +++ b/fs/fs-writeback.c @@ -1479,7 +1479,7 @@ __writeback_single_inode(struct inode *inode, struct writeback_control *wbc) * change I_DIRTY_TIME into I_DIRTY_SYNC. */ if ((inode->i_state & I_DIRTY_TIME) && - (wbc->sync_mode == WB_SYNC_ALL || wbc->for_sync || + (wbc->sync_mode == WB_SYNC_ALL || time_after(jiffies, inode->dirtied_time_when + dirtytime_expire_interval * HZ))) { trace_writeback_lazytime(inode); |