diff options
| author | Byungchul Park <byungchul.park@lge.com> | 2017-08-07 17:45:39 +0900 |
|---|---|---|
| committer | Al Viro <viro@zeniv.linux.org.uk> | 2017-08-28 00:50:23 -0400 |
| commit | b9ea557ee9b9c4e0446851d955c1283bd76a9ce8 (patch) | |
| tree | 9fc76aaec63060ab9c834ecda6a569d31685f8af /fs/file_table.c | |
| parent | 29785735788be2450c5f3b1fda61864aaeca38fd (diff) | |
| download | lwn-b9ea557ee9b9c4e0446851d955c1283bd76a9ce8.tar.gz lwn-b9ea557ee9b9c4e0446851d955c1283bd76a9ce8.zip | |
fput: Don't reinvent the wheel but use existing llist API
Although llist provides proper APIs, they are not used. Make them used.
Signed-off-by: Byungchul Park <byungchul.park@lge.com>
Reviewed-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/file_table.c')
| -rw-r--r-- | fs/file_table.c | 12 |
1 files changed, 5 insertions, 7 deletions
diff --git a/fs/file_table.c b/fs/file_table.c index 72e861a35a7f..61517f57f8ef 100644 --- a/fs/file_table.c +++ b/fs/file_table.c @@ -233,12 +233,10 @@ static LLIST_HEAD(delayed_fput_list); static void delayed_fput(struct work_struct *unused) { struct llist_node *node = llist_del_all(&delayed_fput_list); - struct llist_node *next; + struct file *f, *t; - for (; node; node = next) { - next = llist_next(node); - __fput(llist_entry(node, struct file, f_u.fu_llist)); - } + llist_for_each_entry_safe(f, t, node, f_u.fu_llist) + __fput(f); } static void ____fput(struct callback_head *work) @@ -312,7 +310,7 @@ void put_filp(struct file *file) } void __init files_init(void) -{ +{ filp_cachep = kmem_cache_create("filp", sizeof(struct file), 0, SLAB_HWCACHE_ALIGN | SLAB_PANIC, NULL); percpu_counter_init(&nr_files, 0, GFP_KERNEL); @@ -331,4 +329,4 @@ void __init files_maxfiles_init(void) n = ((totalram_pages - memreserve) * (PAGE_SIZE / 1024)) / 10; files_stat.max_files = max_t(unsigned long, n, NR_FILE); -} +} |