diff options
| author | Olof Johansson <olof@lixom.net> | 2008-04-28 02:16:32 -0700 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2008-04-28 08:58:47 -0700 |
| commit | 9f354858b8ea29e969b82dd96caea376157d76ca (patch) | |
| tree | b76f572fe64c80578f23fbd754867a838ebd5fa9 /fs/fat/inode.c | |
| parent | 0607fd02587a6b4b086dc746d63123c1f284db68 (diff) | |
| download | lwn-9f354858b8ea29e969b82dd96caea376157d76ca.tar.gz lwn-9f354858b8ea29e969b82dd96caea376157d76ca.zip | |
fatfs: fix build warning with 64k PAGE_SIZE
Annoying gcc warning:
fs/fat/inode.c: In function 'fat_fill_super':
fs/fat/inode.c:1222: warning: comparison is always false due to limited range of data type
Change it to compare with 4K instead of PAGE_CACHE_SIZE, as suggested
by OGAWA-san.
[FAT spec says: logical_sector_size should be 512, 1024, 2048 4096]
So, at least for now, we limit it to 4096.
Signed-off-by: Olof Johansson <olof@lixom.net>
Signed-off-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/fat/inode.c')
| -rw-r--r-- | fs/fat/inode.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/fat/inode.c b/fs/fat/inode.c index bf918929e793..5f522a55b596 100644 --- a/fs/fat/inode.c +++ b/fs/fat/inode.c @@ -1226,7 +1226,7 @@ int fat_fill_super(struct super_block *sb, void *data, int silent, le16_to_cpu(get_unaligned((__le16 *)&b->sector_size)); if (!is_power_of_2(logical_sector_size) || (logical_sector_size < 512) - || (PAGE_CACHE_SIZE < logical_sector_size)) { + || (logical_sector_size > 4096)) { if (!silent) printk(KERN_ERR "FAT: bogus logical sector size %u\n", logical_sector_size); |