diff options
| author | Christoph Hellwig <hch@lst.de> | 2011-01-14 13:07:30 +0100 |
|---|---|---|
| committer | Al Viro <viro@zeniv.linux.org.uk> | 2011-01-17 02:25:30 -0500 |
| commit | 64c23e86873ee410554d6d1c76b60da47025e96f (patch) | |
| tree | b30c5ff8782ebfdec6956d7834f796731fd3a1d4 /fs/ext4 | |
| parent | eb745dbccce56f1bbe3f80b95ad2a325145171c2 (diff) | |
| download | lwn-64c23e86873ee410554d6d1c76b60da47025e96f.tar.gz lwn-64c23e86873ee410554d6d1c76b60da47025e96f.zip | |
make the feature checks in ->fallocate future proof
Instead of various home grown checks that might need updates for new
flags just check for any bit outside the mask of the features supported
by the filesystem. This makes the check future proof for any newly
added flag.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/ext4')
| -rw-r--r-- | fs/ext4/extents.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c index c4068f6abf03..4bdd160854eb 100644 --- a/fs/ext4/extents.c +++ b/fs/ext4/extents.c @@ -3645,7 +3645,7 @@ long ext4_fallocate(struct inode *inode, int mode, loff_t offset, loff_t len) unsigned int credits, blkbits = inode->i_blkbits; /* We only support the FALLOC_FL_KEEP_SIZE mode */ - if (mode && (mode != FALLOC_FL_KEEP_SIZE)) + if (mode & ~FALLOC_FL_KEEP_SIZE) return -EOPNOTSUPP; /* |