diff options
| author | Colin Ian King <colin.king@canonical.com> | 2019-08-12 14:29:38 -0400 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2019-08-12 14:29:38 -0400 |
| commit | 7a14826ede1d714f0bb56de8167c0e519041eeda (patch) | |
| tree | e7c34a9f0263a46859b7e8f2365fa093e017e094 /fs/ext4 | |
| parent | cd2d99229dc96219547e6349841e1aad851c6acc (diff) | |
| download | lwn-7a14826ede1d714f0bb56de8167c0e519041eeda.tar.gz lwn-7a14826ede1d714f0bb56de8167c0e519041eeda.zip | |
ext4: set error return correctly when ext4_htree_store_dirent fails
Currently when the call to ext4_htree_store_dirent fails the error return
variable 'ret' is is not being set to the error code and variable count is
instead, hence the error code is not being returned. Fix this by assigning
ret to the error return code.
Addresses-Coverity: ("Unused value")
Fixes: 8af0f0822797 ("ext4: fix readdir error in the case of inline_data+dir_index")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Diffstat (limited to 'fs/ext4')
| -rw-r--r-- | fs/ext4/inline.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/ext4/inline.c b/fs/ext4/inline.c index 88cdf3c90bd1..2fec62d764fa 100644 --- a/fs/ext4/inline.c +++ b/fs/ext4/inline.c @@ -1416,7 +1416,7 @@ int ext4_inlinedir_to_tree(struct file *dir_file, err = ext4_htree_store_dirent(dir_file, hinfo->hash, hinfo->minor_hash, de, &tmp_str); if (err) { - count = err; + ret = err; goto out; } count++; |