diff options
| author | Jan Kara <jack@suse.cz> | 2023-03-29 17:49:37 +0200 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2023-04-14 19:56:53 -0400 |
| commit | e360c6ed727401ad1a3b5080f06d2ec3a4b75f5b (patch) | |
| tree | c84897e481bb2898a44e980f0b114df0633daf6b /fs/ext4 | |
| parent | 1f1a55f0bf069799edd5f21a99ac1e3b10ebafee (diff) | |
| download | lwn-e360c6ed727401ad1a3b5080f06d2ec3a4b75f5b.tar.gz lwn-e360c6ed727401ad1a3b5080f06d2ec3a4b75f5b.zip | |
ext4: Drop special handling of journalled data from ext4_sync_file()
Now that ext4_writepages() make sure all pages with journalled data are
stable on disk, we don't need special handling of journalled data in
ext4_sync_file().
Signed-off-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20230329154950.19720-6-jack@suse.cz
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Diffstat (limited to 'fs/ext4')
| -rw-r--r-- | fs/ext4/fsync.c | 11 |
1 files changed, 0 insertions, 11 deletions
diff --git a/fs/ext4/fsync.c b/fs/ext4/fsync.c index 027a7d7037a0..f65fdb27ce14 100644 --- a/fs/ext4/fsync.c +++ b/fs/ext4/fsync.c @@ -153,23 +153,12 @@ int ext4_sync_file(struct file *file, loff_t start, loff_t end, int datasync) goto out; /* - * data=writeback,ordered: * The caller's filemap_fdatawrite()/wait will sync the data. * Metadata is in the journal, we wait for proper transaction to * commit here. - * - * data=journal: - * filemap_fdatawrite won't do anything (the buffers are clean). - * ext4_force_commit will write the file data into the journal and - * will wait on that. - * filemap_fdatawait() will encounter a ton of newly-dirtied pages - * (they were dirtied by commit). But that's OK - the blocks are - * safe in-journal, which is all fsync() needs to ensure. */ if (!sbi->s_journal) ret = ext4_fsync_nojournal(inode, datasync, &needs_barrier); - else if (ext4_should_journal_data(inode)) - ret = ext4_force_commit(inode->i_sb); else ret = ext4_fsync_journal(inode, datasync, &needs_barrier); |