diff options
| author | Jan Kara <jack@suse.cz> | 2023-03-29 17:49:41 +0200 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2023-04-14 19:56:53 -0400 |
| commit | 7c375870fdc5f50a001f8265cd8744a78d2d43ab (patch) | |
| tree | 121cbfae8fb7a11eece6a1e5ff1aeebd274d6c22 /fs/ext4 | |
| parent | 56c2a0e3d90d3822fab157883957523e327bc9ae (diff) | |
| download | lwn-7c375870fdc5f50a001f8265cd8744a78d2d43ab.tar.gz lwn-7c375870fdc5f50a001f8265cd8744a78d2d43ab.zip | |
ext4: Drop special handling of journalled data from ext4_quota_on()
Now that ext4_writepages() makes sure all journalled data is committed
and checkpointed, sync_filesystem() call done by dquot_quota_on() is
enough for quota IO to see uptodate data. So drop special handling of
journalled data from ext4_quota_on().
Signed-off-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20230329154950.19720-10-jack@suse.cz
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Diffstat (limited to 'fs/ext4')
| -rw-r--r-- | fs/ext4/super.c | 17 |
1 files changed, 0 insertions, 17 deletions
diff --git a/fs/ext4/super.c b/fs/ext4/super.c index 54fb600bf51f..a876ebd534a8 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -6881,23 +6881,6 @@ static int ext4_quota_on(struct super_block *sb, int type, int format_id, sb_dqopt(sb)->flags &= ~DQUOT_NOLIST_DIRTY; } - /* - * When we journal data on quota file, we have to flush journal to see - * all updates to the file when we bypass pagecache... - */ - if (EXT4_SB(sb)->s_journal && - ext4_should_journal_data(d_inode(path->dentry))) { - /* - * We don't need to lock updates but journal_flush() could - * otherwise be livelocked... - */ - jbd2_journal_lock_updates(EXT4_SB(sb)->s_journal); - err = jbd2_journal_flush(EXT4_SB(sb)->s_journal, 0); - jbd2_journal_unlock_updates(EXT4_SB(sb)->s_journal); - if (err) - return err; - } - lockdep_set_quota_inode(path->dentry->d_inode, I_DATA_SEM_QUOTA); err = dquot_quota_on(sb, type, format_id, path); if (!err) { |